| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Wed, 10 Mar 2010 09:05:07 +0800 From: "jack wang" <jack_wang@...sh.com> To: "'Julia Lawall'" <julia@...u.dk>, <lindar_liu@...sh.com>, "'James E.J. Bottomley'" <James.Bottomley@...e.de>, <linux-scsi@...r.kernel.org>, <linux-kernel@...r.kernel.org>, <kernel-janitors@...r.kernel.org> Subject: RE: [PATCH 3/5] drivers/scsi: drop redundant memset From: Julia Lawall <julia@...u.dk> The region set by the call to memset is immediately overwritten by the subsequent call to memcpy. The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // <smpl> @@ expression e1,e2,e3,e4; @@ - memset(e1,e2,e3); memcpy(e1,e4,e3); // </smpl> Signed-off-by: Julia Lawall <julia@...u.dk> --- drivers/scsi/pm8001/pm8001_hwi.c | 1 - 1 file changed, 1 deletion(-) diff -u -p a/drivers/scsi/pm8001/pm8001_hwi.c b/drivers/scsi/pm8001/pm8001_hwi.c --- a/drivers/scsi/pm8001/pm8001_hwi.c +++ b/drivers/scsi/pm8001/pm8001_hwi.c @@ -4389,7 +4389,6 @@ pm8001_chip_fw_flash_update_req(struct p return -ENOMEM; } } - memset(buffer, 0, fw_control->len); memcpy(buffer, fw_control->buffer, fw_control->len); flash_update_info.sgl.addr = cpu_to_le64(phys_addr); flash_update_info.sgl.im_len.len = cpu_to_le32(fw_control->len); [Jack] Thanks Julia. Acked-by: Jack Wang <jack_wang@...sh.com> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists