linux-kernel - Re: Tuxradar patching article and [PATCH] scripts/cvt_kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 10 Mar 2010 19:32:16 +0100
From:	Stefan Richter <stefanr@...6.in-berlin.de>
To:	Joe Perches <joe@...ches.com>
CC:	LKML <linux-kernel@...r.kernel.org>,
	Greg Kroah-Hartman <gregkh@...e.de>,
	devel <devel@...verdev.osuosl.org>,
	Andy Whitcroft <apw@...dowen.org>
Subject: Re: Tuxradar patching article and [PATCH] scripts/cvt_kernel_style.pl

Joe Perches wrote:
> There was an article published recently:
> http://www.tuxradar.com/content/newbies-guide-hacking-linux-kernel
> that seems to have prompted several new contributors (welcome)
> to create style reformatting patches.

Uh oh.  How can a newcomer know what good style is?

Please start your career of kernel contributions differently:
  - Test new kernels.  Report issues and work with the developers to
    get the issues fixed.
  - If there is a bug which nags you but there doesn't seem to be
    an active developer to fix it anytime soon, try to fix it yourself.

Or if you are aware of a small RFE for a subsystem which interests you
personally, try to implement that small feature.

It doesn't make sense to start kernel development with something which
you are likely not going to connect with personally.  (Reformat others'
code?  Better write your own code, i.e. a bug fix or a small feature.)

PS:
I am also saying this because I repeatedly see "style fixes" posted
which are questionable at best, or actually degrade style, or even
introduce bugs.

PPS:
How can a script know what good style is?
-- 
Stefan Richter
-=====-==-=- --== -=-=-
http://arcgraph.de/sr/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/