| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Thu, 11 Mar 2010 08:18:59 +0900
From: OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
To: Andy Shevchenko <andy.shevchenko@...il.com>
Cc: linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/5] fs: fat: use hex_asc_lo/hex_asc_hi instead of custom one
Andy Shevchenko <andy.shevchenko@...il.com> writes:
> if (uni_xlate == 1) {
> - *op = ':';
> - for (k = 4; k > 0; k--) {
> - nc = ec & 0xF;
> - op[k] = nc > 9 ? nc + ('a' - 10)
> - : nc + '0';
> - ec >>= 4;
> - }
> - op += 5;
> + *op++ = ':';
> + *op++ = hex_asc_hi(ec >> 8);
> + *op++ = hex_asc_lo(ec >> 8);
> + *op++ = hex_asc_hi(ec);
> + *op++ = hex_asc_lo(ec);
> len -= 5;
Why doesn't this use pack_hex_byte()?
Thanks.
--
OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists