lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 11 Mar 2010 00:10:00 -0800 From: Joe Perches <joe@...ches.com> To: Andy Shevchenko <andy.shevchenko@...il.com> Cc: OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>, linux-kernel@...r.kernel.org Subject: Re: [PATCH 4/5] fs: fat: use hex_asc_lo/hex_asc_hi instead of custom one On Thu, 2010-03-11 at 09:59 +0200, Andy Shevchenko wrote: > On Thu, Mar 11, 2010 at 9:21 AM, Joe Perches <joe@...ches.com> wrote: > >> > + *op++ = hex_asc_hi(ec >> 8); > >> > + *op++ = hex_asc_lo(ec >> 8); > >> > + *op++ = hex_asc_hi(ec); > >> > + *op++ = hex_asc_lo(ec); > >> Why doesn't this use pack_hex_byte()? > > or snprintf > sprintf looks like overkill here. It's shorter and more intelligible though op += sprintf(op, ":%04x:%04x", etc) cheers, Joe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists