linux-kernel - Re: [Xen-devel] [PATCH 0 of 5] PV on HVM Xen

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 12 Mar 2010 13:53:18 -0800
From:	Jeremy Fitzhardinge <jeremy@...p.org>
To:	Stefano Stabellini <stefano.stabellini@...citrix.com>
CC:	Sheng Yang <sheng@...ux.intel.com>,
	"xen-devel@...ts.xensource.com" <xen-devel@...ts.xensource.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Ian Pratt <Ian.Pratt@...citrix.com>,
	Fraser <Keir.Fraser@...citrix.com>
Subject: Re: [Xen-devel] [PATCH 0 of 5] PV on HVM Xen

On 03/12/2010 02:42 AM, Stefano Stabellini wrote:
> On Fri, 12 Mar 2010, Sheng Yang wrote:
>    
>> On Wednesday 10 March 2010 23:46:54 Stefano Stabellini wrote:
>>      
>>> Hi all,
>>>        
>> Stefano,
>>
>> And next time when you send out the patch, please be more respect to my work.
>>
>> You dropped all the original author(me) of patchset, and only add a sign-off
>> for me. If you don't aware the difference, here is a snippet of
>> linux/Documentation/SummittingPatches
>>
>>      
> I am truly sorry and apologise for it, I would never want to give you
> the impression of being disrespectful of you and your work.
> If you pay attention I manually wrote in the comments of all the past
> versions of the patches that you were the original author, this time I
> just forgot.
> I guess it is really the time I start using git-send-email :)
>
> Your work has been really important for my series and you deserve the
> credit for it independently from which patch series gets applied.
>    

Best practise for this kind of thing is to use Sheng's patch verbatim, 
then apply a separate delta on top to make the changes you want.  That way:

    * credit can be property attributed
    * it helps with maintaining two parallel-but-converging git
      branches, because all the common stuff is genuinely common, and
      the variations can work from there, and
    * if Sheng updates his patches (review, bugfix, etc), then we can
      easily see how those changes affect your changes.

For example, I just rebased your previous patch posting so that it is 
rooted on Sheng's two base patches, as they're completely common.

The latest of both patches is in xen/pvhvm-sheng and -stefano.

     J
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/