linux-kernel - Re: [PATCH] kobject: Fix kobject_set_name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 11 Mar 2010 20:15:18 -0800
From:	Greg KH <greg@...ah.com>
To:	Eric Dumazet <eric.dumazet@...il.com>,
	Kay Sievers <kay.sievers@...y.org>
Cc:	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] kobject: Fix kobject_set_name_vargs()

On Thu, Mar 11, 2010 at 09:50:52PM +0100, Eric Dumazet wrote:
> In case of kvasprintf() failure, we can leak old kobject name.
> 
> Signed-off-by: Eric Dumazet <eric.dumazet@...il.com>
> ---
> diff --git a/lib/kobject.c b/lib/kobject.c
> index 8115eb1..1247c57 100644
> --- a/lib/kobject.c
> +++ b/lib/kobject.c
> @@ -222,8 +222,10 @@ int kobject_set_name_vargs(struct kobject *kobj, const char *fmt,
>  		return 0;
>  
>  	kobj->name = kvasprintf(GFP_KERNEL, fmt, vargs);
> -	if (!kobj->name)
> +	if (!kobj->name) {
> +		kobj->name = old_name;
>  		return -ENOMEM;
> +	}

Are you sure?  I think we've been over this very thing many times in the
past...

Kay, I can't recall the issue here, can you?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/