linux-kernel - Re: [PATCH] base firmware: Fix BUG from sysfs attributes change in commit a2db6842873c8e5a70652f278d469128cb52db70

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 14 Mar 2010 11:04:25 -0700 (PDT)
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Wolfram Sang <w.sang@...gutronix.de>
cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	Jiri Kosina <jkosina@...e.cz>,
	Larry Finger <Larry.Finger@...inger.net>,
	WANG Cong <xiyou.wangcong@...il.com>,
	Greg Kroah-Hartman <gregkh@...e.de>, Tejun Heo <tj@...nel.org>
Subject: Re: [PATCH] base firmware: Fix BUG from sysfs attributes change in
 commit a2db6842873c8e5a70652f278d469128cb52db70


On Sun, 14 Mar 2010, Wolfram Sang wrote:
>
> coccinelle can apply semantic patches, rough description here [1]. So I wrote
> one which checks for every c-file in the kernel-tree:
>
> - Is there a structure containing (bin_)attribute?
> - Does a function declare a pointer to such a structure?
> - Is this pointer then used for a sysfs_create(_bin)_file?
> - If so, has there been a call to sysfs(_bin)_attr_init before?
>
> If not -> report. As coccinelle works on an abstract level of the code (not on
> source-code level), it can follow code-paths and such. Really nice tool, once
> you gathered the information to learn it.
> 
> The outcome are those patches:
> 
> http://patchwork.kernel.org/patch/85214/
>
> http://patchwork.kernel.org/patch/85212/
> (which is pretty much the same like the patch originating this thread. I vote
> very much for dropping those patches and use
> http://patchwork.kernel.org/patch/84814/ instead!)
> 
> http://patchwork.kernel.org/patch/85213/

Hey, goodie.  Can we merge the trivial one-liners into a single patch that 
fixes the issue?

Also, that "firmware_attr_data" thing should probably be marked 'const', 
no? That should make it more obvious that it's ok to share across multiple 
different firmware file, I think.

> Eric, if you have a bit of time, acking these patches would help them getting
> accepted for the mips/rtc-trees, IMHO.

You removed everybody from the Cc: line, so I doubt Eric even sees your 
email. I added the cc's back in.

			Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/