lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 14 Mar 2010 12:49:08 -0400 (EDT) From: "Robert P. J. Day" <rpjday@...shcourse.ca> To: Tilman Schmidt <t.schmidt@...enixsoftware.de> cc: Linux Kernel Mailing List <linux-kernel@...r.kernel.org> Subject: Re: should new kfifo implementation really be exporting that much? On Sun, 14 Mar 2010, Tilman Schmidt wrote: > Am 14.03.2010 15:57 schrieb Robert P. J. Day: > > as a short followup, kfifo.h strongly implies that a lot of the > > above shouldn't be exported: > > > > ... > > /* > > * __kfifo_in_... internal functions for put date into the fifo > > * do not call it directly, use kfifo_in_rec() instead > > */ > > ... > > > > anyway, you get the idea. it would seem that a lot of those EXPORTs > > should be removed, no? > > If you look at kfifo_in_rec(), it's a static inline void function > defined in kfifo.h and which calls __kfifo_in_generic() or > __kfifo_in_rec(). I don't think you'll be able to make that work > without exporting those functions. huh. i believe you're correct. i'll take a closer look but i still get this feeling that there's something ... messy about that API. case in point: kfifo_in_rec() is *not* being exported, but a routine that it invokes -- __kfifo_in_generic() -- *is* being exported. doesn't that just seem a bit backwards? anyway, off to the gym to bike and see which duke team shows up for georgia tech. rday -- ======================================================================== Robert P. J. Day Waterloo, Ontario, CANADA Linux Consulting, Training and Kernel Pedantry. Web page: http://crashcourse.ca Twitter: http://twitter.com/rpjday ======================================================================== -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists