linux-kernel - Re: [PATCH] staging: winbond: mds.c whitspace, indentation etc.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 15 Mar 2010 20:14:27 +0200
From:	Pekka Enberg <penberg@...helsinki.fi>
To:	Lars Lindley <lindley@...ote.org>
CC:	Dan Carpenter <error27@...il.com>, gregkh@...e.de, greg@...ah.com,
	pavel@....cz, diegoliz@...il.com, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org, stefanr@...6.in-berlin.de
Subject: Re: [PATCH] staging: winbond: mds.c whitspace, indentation etc.

Lars Lindley wrote:
> On 2010-03-15 17:52, Pekka Enberg wrote:
>> Dan Carpenter wrote:
>>> On Mon, Mar 15, 2010 at 05:36:13PM +0100, Lars Lindley wrote:
>>>> I fixed most of the problems found by checkpatch.pl.
>>>> Some long lines are left and some KERN_..
>>>> This is a new revised patch against master with changes
>>>> after comments from Stefan Richter and Dan Carpenter.
>>>> Forget the old one.
>>>>
>>>> Signed-off-by: Lars Lindley <lindley@...ote.org>
>>>> Acked-by: Pavel Machek <pavel@....cz>
>>> Acked-by: Dan Carpenter <error27@...il.com>
>> It's pretty difficult to say if anything changed based on the diff so
>> would you mind posting before and after output of 'size mds.o', please?
>>
> Hi Pekka.
> 
> Before:
> lali@...er2 ~/linux3/linux-2.6 $ size drivers/staging/winbond/mds.o
>    text	   data	    bss	    dec	    hex	filename
>    2804	      0	      0	   2804	    af4	drivers/staging/winbond/mds.o
> 
> After:
> lali@...er2 ~/linux2/linux-2.6 $ size drivers/staging/winbond/mds.o
>    text	   data	    bss	    dec	    hex	filename
>    2804	      0	      0	   2804	    af4	drivers/staging/winbond/mds.o
> 
> diff:
> lali@...er2 ~/linux2/linux-2.6 $ diff ../../linux3/linux-2.6/drivers/staging/winbond/mds.o drivers/staging/winbond/mds.o
> lali@...er2 ~/linux2/linux-2.6 $ 
> 
> linux3 is a clean tree and linux2 the one i'm working on..

Acked-by: Pekka Enberg <penberg@...helsinki.fi>

Greg, can you pick up my typedef cleanups and this patch to -staging?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/