linux-kernel - Re: [PATCH v2] perf: Fix unexported generic perf_arch_fetch_caller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 16 Mar 2010 00:54:52 +0100
From:	Frederic Weisbecker <fweisbec@...il.com>
To:	Stephen Rothwell <sfr@...b.auug.org.au>
Cc:	Ingo Molnar <mingo@...e.hu>, LKML <linux-kernel@...r.kernel.org>,
	" H . Peter Anvin " <hpa@...or.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Linux Next <linux-next@...r.kernel.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Xiao Guangrong <xiaoguangrong@...fujitsu.com>,
	Paul Mackerras <paulus@...ba.org>
Subject: Re: [PATCH v2] perf: Fix unexported generic
	perf_arch_fetch_caller_regs

On Tue, Mar 16, 2010 at 09:33:55AM +1100, Stephen Rothwell wrote:
> Hi Frederic,
> 
> On Mon, 15 Mar 2010 23:17:22 +0100 Frederic Weisbecker <fweisbec@...il.com> wrote:
> >
> > perf_arch_fetch_caller_regs() is exported for the overriden x86
> > version, but not for the generic weak version.
> > As a general rule, weak functions should have their symbol exported
>                                           ^
> "not"


Ooh, right.


 
> > in the same file they are defined.
> > 
> > So let's export it on trace_event_perf.c as it is used by trace
> > events only.
> 
> Otherwise, looks good (though I haven't tested it).



I've tested with some trace event built as module and it looks
fine so far.

Thanks.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/