lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 15 Mar 2010 07:48:31 +0100 From: Marek Szyprowski <m.szyprowski@...sung.com> To: 'Liam Girdwood' <lrg@...mlogic.co.uk>, 'Kyungmin Park' <kyungmin.park@...sung.com> Cc: 'axel lin' <axel.lin@...il.com>, 'linux-kernel' <linux-kernel@...r.kernel.org>, 'Mark Brown' <broonie@...nsource.wolfsonmicro.com> Subject: RE: [PATCH] lp3971: Fix BUCK_VOL_CHANGE_SHIFT logic Hello, On Thursday, March 11, 2010 12:18 PM Liam Girdwood wrote: > On Thu, 2010-03-11 at 11:04 +0000, Mark Brown wrote: > > On Thu, Mar 11, 2010 at 09:56:34AM +0800, axel lin wrote: > > > From 99175ed0f281d54efdaf8eef548077a8f0b4924a Mon Sep 17 00:00:00 2001 > > > From: Axel Lin <axel.lin@...il.com> > > > Date: Thu, 11 Mar 2010 09:50:07 +0800 > > > Subject: [PATCH] lp3971: Fix BUCK_VOL_CHANGE_SHIFT logic > > > > > > Given x=0,1,2, current implementation of BUCK_VOL_CHANGE_SHIFT(x) returns 0,4,8. > > > The correct return value should be 0,4,6. > > > This patch fix the logic. > > > > > > Signed-off-by: Axel Lin <axel.lin@...il.com> > > > > Acked-by: Mark Brown <broonie@...nsource.wolfsonmicro.com> > > > > with the same comment about ideally wanting someone who worked on the > > driver previously to check stuff. > > Marek, Kyungmin, could someone please test/ack this before both are > applied. Acked-by: Marek Szyprowski <m.szyprowski@...sung.com> Axel was right, my bit arithmetic was definitely wrong. Again, thanks for spotting it and I'm really sorry You had lost some time debugging it. Best regards -- Marek Szyprowski Samsung Poland R&D Center -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists