| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Fri, 19 Mar 2010 12:53:23 -0500 From: Mark Rustad <mrustad@...il.com> To: Stefan Richter <stefanr@...6.in-berlin.de> Cc: David Howells <dhowells@...hat.com>, torvalds@...l.org, akpm@...ux-foundation.org, sgruszka@...hat.com, davem@...emloft.net, linux-kernel@...r.kernel.org, "Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>, Randy Dunlap <rdunlap@...otime.net> Subject: Re: [PATCH] Document Linux's circular buffering capabilities On Mar 15, 2010, at 8:43 AM, Stefan Richter wrote: > David Howells wrote: >> How about adding a bit: >> >> Note the use of ACCESS_ONCE() in both algorithms to read the opposition index. >> This prevents the compiler from discarding and reloading its cached value - >> -which some compilers will do across smp_read_barrier_depends(). >> +which some compilers will do across smp_read_barrier_depends(). This isn't >> +strictly needed if you can be sure that the opposition index will _only_ be >> +used the once. > > Yes, thanks. (The last "the" is superfluous.) Maybe it would be clearer to change "the once" to "the one time" or "that one time". "the once" reads too much like an error which may lead to it being "corrected" some day, most likely then losing the intended meaning. -- Mark Rustad, MRustad@...il.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists