lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 20 Mar 2010 15:24:03 +0300 From: Dan Carpenter <error27@...il.com> To: Felipe Balbi <felipe.balbi@...ia.com> Cc: Greg Kroah-Hartman <gregkh@...e.de>, David Brownell <dbrownell@...rs.sourceforge.net>, Sergei Shtylyov <sshtylyov@...mvista.com>, Ajay Kumar Gupta <ajay.gupta@...com>, linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org Subject: [patch] musb: potential use after free We assign "urb->hcpriv = qh;" a few lines down. I'm pretty sure we want it "urb->hcpriv" to be NULL not a freed value. Signed-off-by: Dan Carpenter <error27@...il.com> --- Found with a static checker. I don't have the hardware to test this. diff --git a/drivers/usb/musb/musb_host.c b/drivers/usb/musb/musb_host.c index dec896e..877d20b 100644 --- a/drivers/usb/musb/musb_host.c +++ b/drivers/usb/musb/musb_host.c @@ -2042,6 +2042,7 @@ static int musb_urb_enqueue( * odd, rare, error prone, but legal. */ kfree(qh); + qh = NULL; ret = 0; } else ret = musb_schedule(musb, qh, -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists