linux-kernel - bug report: ceph: && vs ||

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 20 Mar 2010 15:39:26 +0300
From:	Dan Carpenter <error27@...il.com>
To:	Sage Weil <sage@...dream.net>
Cc:	ceph-devel@...ts.sourceforge.net, linux-kernel@...r.kernel.org
Subject: bug report: ceph: && vs ||



  1772          /* correct session? */
  1773          if (!req->r_session && req->r_session != session) {

	Is this supposed to || here?  We know "session" is non-NULL at
	the point because we already dereferenced it.  If "req->r_session"
	is null then the second condition is always true.

	Also we dereference "req->r_session" later on without checking.

  1774                  pr_err("mdsc_handle_reply got %llu on session mds%d"
  1775                         " not mds%d\n", tid, session->s_mds,
  1776                         req->r_session ? req->r_session->s_mds : -1);
  1777                  mutex_unlock(&mdsc->mutex);
  1778                  goto out;
  1779          }
  1780

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/