linux-kernel - Re: [PATCH 1/2] Hwmon: f71882fg: fixed braces coding style issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 22 Mar 2010 11:20:13 +0100
From:	Jean Delvare <khali@...ux-fr.org>
To:	Hans de Goede <hdegoede@...hat.com>
Cc:	Giel van Schijndel <me@...tis.eu>,
	Jonathan Cameron <jic23@....ac.uk>, lm-sensors@...sensors.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] Hwmon: f71882fg: fixed braces coding style issues

On Mon, 22 Mar 2010 10:30:54 +0100, Hans de Goede wrote:
> Ack.
> 
> Acked-by: Hans de Goede <hdegoede@...hat.com>

Applied, thanks.

> On 03/21/2010 04:37 PM, Giel van Schijndel wrote:
> > Fixed several coding style issues.
> >
> > Signed-off-by: Giel van Schijndel<me@...tis.eu>
> > ---
> >   drivers/hwmon/f71882fg.c |   11 +++++------
> >   1 files changed, 5 insertions(+), 6 deletions(-)
> >
> > diff --git a/drivers/hwmon/f71882fg.c b/drivers/hwmon/f71882fg.c
> > index a95fa42..21bc661 100644
> > --- a/drivers/hwmon/f71882fg.c
> > +++ b/drivers/hwmon/f71882fg.c
> > @@ -866,11 +866,11 @@ static int superio_inw(int base, int reg)
> >   static inline void superio_enter(int base)
> >   {
> >   	/* according to the datasheet the key must be send twice! */
> > -	outb( SIO_UNLOCK_KEY, base);
> > -	outb( SIO_UNLOCK_KEY, base);
> > +	outb(SIO_UNLOCK_KEY, base);
> > +	outb(SIO_UNLOCK_KEY, base);
> >   }
> >
> > -static inline void superio_select( int base, int ld)
> > +static inline void superio_select(int base, int ld)
> >   {
> >   	outb(SIO_REG_LDSEL, base);
> >   	outb(ld, base + 1);
> > @@ -945,7 +945,7 @@ static struct f71882fg_data *f71882fg_update_device(struct device *dev)
> >   	mutex_lock(&data->update_lock);
> >
> >   	/* Update once every 60 seconds */
> > -	if ( time_after(jiffies, data->last_limits + 60 * HZ ) ||
> > +	if (time_after(jiffies, data->last_limits + 60 * HZ) ||
> >   			!data->valid) {
> >   		if (data->type == f71882fg || data->type == f71889fg) {
> >   			data->in1_max =
> > @@ -2151,8 +2151,7 @@ static int __init f71882fg_find(int sioaddr, unsigned short *address,
> >   	}
> >
> >   	*address = superio_inw(sioaddr, SIO_REG_ADDR);
> > -	if (*address == 0)
> > -	{
> > +	if (*address == 0) {
> >   		printk(KERN_WARNING DRVNAME ": Base address not set\n");
> >   		goto exit;
> >   	}


-- 
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/