| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Mon, 22 Mar 2010 11:58:14 +0100 From: Pavel Machek <pavel@....cz> To: Lars Lindley <lindley@...ote.org> Cc: Pekka Enberg <penberg@...helsinki.fi>, gregkh@...e.de, greg@...ah.com, devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] staging: winbond: wb35reg_f.h Coding style fixes. > On 2010-03-22 10:57, Pekka Enberg wrote: > > On Mon, Mar 22, 2010 at 11:45 AM, Lars Lindley <lindley@...ote.org> wrote: > >> On 2010-03-22 08:16, Pekka Enberg wrote: > >>>> +unsigned char Wb35Reg_initial(struct hw_data *HwData); > >>> > >>> Lets avoid CamelCase for the arguments so "hw_data" here, for example. I > >>> see the same thing elsewhere in this patch as well. > >>> > >> I thought struct hw_data *hw_data looked a bit confusing..Thats why I left > >> CamelCase alone for now. I can make it like that if you want.. > > > > Yes please. > > > > > Here's a new patch against master that fixes CamelCase too. > > > > [PATCH] staging: winbond: wb35reg_f.h Coding style fixes. > > I fixed the checkpatch things except a couple of long lines. > I also removed hungarian notation and CamelCase from the argument names > and some "commented away" code. > > Signed-off-by: Lars Lindley <lindley@...ote.org> ACK. -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists