linux-kernel - Re: [rt2x00-users] [PATCH RFC] rt2500usb: disable broken HW encryption by default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 23 Mar 2010 10:36:58 +0100
From:	Ivo Van Doorn <ivdoorn@...il.com>
To:	Ondrej Zary <linux@...nbow-software.org>
Cc:	rt2x00 Users List <users@...x00.serialmonkey.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [rt2x00-users] [PATCH RFC] rt2500usb: disable broken HW 
	encryption by default

On Tue, Mar 23, 2010 at 10:27 AM, Ondrej Zary
<linux@...nbow-software.org> wrote:
> On Monday 22 March 2010, Ivo Van Doorn wrote:
>> >> But I though it was mentioned that disabling HW crypto didn't solve
>> >> the issue due to a second bug in a later kernel?
>> >
>> > That was a false positive. Probably because the device was not unplugged
>> > between the tests (and looks like the driver does not initialize the chip
>> > completely). It's not reliable, it sometimes stops working after reboot.
>>
>> Ah well that at least simplifies the problem. I'll have to retest rt2500usb
>> soon to see why the HW crypto failed. I am sure I had it working for WEP,
>> WPA and WPA2
>> before I submitted the patch.
>
> So let's try to fix it instead of disabling.
>
> First, the unrealiability (keeping HW encryption disabled). With the driver
> loaded but not doing anything more, the register dumps are same for both
> working and non-working case (dump-init.txt).
>
> dump-good-connected.txt is a dump after successful association and DHCP
> dump-bad-attempt.txt is a dump after successful association during non-working
> DHCP attempt
> dump-bad-after.txt is a dump after DHCP timed out

With association working, but DHCP failing it most likely means that
somehow the frame was malformatted.
The code for HW crypto alters the frame (alters IV/EIV/ICV data etc).
And that is commonly the source of
problems, because what has to be done depends heavily on the encryption type.

So could you verify which of the encryption types (WEP,WPA,WPA2) is
failing or working? That would give a starting
position on which bytes might be corrupted.

Ivo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/