linux-kernel - Re: [PATCH 1/4] x86: don't include slab.h from arch/x86/include/asm/pgtable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 24 Mar 2010 12:58:05 +0200
From:	Pekka Enberg <penberg@...helsinki.fi>
To:	Tejun Heo <tj@...nel.org>
Cc:	torvalds@...ux-foundation.org, akpm@...ux-foundation.org,
	linux-kernel@...r.kernel.org, Lee.Schermerhorn@...com,
	cl@...ux-foundation.org, mingo@...e.hu, adobriyan@...il.com,
	tglx@...utronix.de, hpa@...or.com, yi.zhu@...el.com,
	reinette.chatre@...el.com, ilw@...ux.intel.com
Subject: Re: [PATCH 1/4] x86: don't include slab.h from arch/x86/include/asm/pgtable_32.h

On Wed, Mar 24, 2010 at 10:48 AM, Tejun Heo <tj@...nel.org> wrote:
> Including slab.h from x86 pgtable_32.h creates a troublesome
> dependency chain w/ ftrace enabled.  The following chain leads to
> inclusion of pgtable_32.h from define_trace.h.
>
>  trace/define_trace.h
>  trace/ftrace.h
>  linux/ftrace_event.h
>  linux/ring_buffer.h
>  linux/mm.h
>  asm/pgtable.h
>  asm/pgtable_32.h
>
> And when slab.h itself defines trace hooks via
>
>  linux/sl[aou]b_def.h
>  linux/kmemtrace.h
>  trace/events/kmem.h
>
> If slab.h is not included before define_trace.h is included, this
> leads to duplicate definitions of kmemtrace hooks or other include
> dependency problems.
>
> pgtable_32.h doesn't need slab.h to begin with.  Don't include it from
> there.
>
> Signed-off-by: Tejun Heo <tj@...nel.org>
> Cc: Ingo Molnar <mingo@...e.hu>
> Cc: Thomas Gleixner <tglx@...utronix.de>
> Cc: H. Peter Anvin <hpa@...or.com>

Acked-by: Pekka Enberg <penberg@...helsinki.fi>

> ---
>  arch/x86/include/asm/pgtable_32.h |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/arch/x86/include/asm/pgtable_32.h b/arch/x86/include/asm/pgtable_32.h
> index 47339a1..2984a25 100644
> --- a/arch/x86/include/asm/pgtable_32.h
> +++ b/arch/x86/include/asm/pgtable_32.h
> @@ -19,7 +19,6 @@
>  #include <asm/paravirt.h>
>
>  #include <linux/bitops.h>
> -#include <linux/slab.h>
>  #include <linux/list.h>
>  #include <linux/spinlock.h>
>
> --
> 1.6.4.2
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/