linux-kernel - Re: [PATCH 1/2] Revert "rt: trivial fix to REMINDER block in init/main.c"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 24 Mar 2010 14:13:07 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	John Kacur <jkacur@...hat.com>
Cc:	Thomas Gleixner <tglx@...utronix.de>,
	lkml <linux-kernel@...r.kernel.org>,
	rt-users <linux-rt-users@...r.kernel.org>,
	Clark Williams <williams@...hat.com>
Subject: Re: [PATCH 1/2] Revert "rt: trivial fix to REMINDER block in
 init/main.c"

On Wed, 2010-03-24 at 18:35 +0100, John Kacur wrote:
> This reverts commit 3e39399ef4a742d994570488994be93ef17d4ef5.
> 
> CONFIG_STACK_TRACER really should not be in the reminder block.
> By default it is not enabled, and has negligible impact.

Correct, the stack trace is based off of the function tracer, which with
dynamic ftrace it does not have any extra impact when not enabled.

Hmm, maybe we should add a warning if it was set on the command line?

Anyway,

Acked-by: Steven Rostedt <rostedt@...dmis.org>

-- Steve

> 
> Signed-off-by: John Kacur <jkacur@...hat.com>
> ---
>  init/main.c |    3 ---
>  1 files changed, 0 insertions(+), 3 deletions(-)
> 
> diff --git a/init/main.c b/init/main.c
> index 48393c0..aa48b7b 100644
> --- a/init/main.c
> +++ b/init/main.c
> @@ -928,9 +928,6 @@ static int __init kernel_init(void * unused)
>  #ifdef CONFIG_PREEMPT_TRACER
>  	printk(KERN_ERR "*        CONFIG_PREEMPT_TRACER                                              *\n");
>  #endif
> -#ifdef CONFIG_STACK_TRACER
> -	printk(KERN_ERR "*        CONFIG_STACK_TRACER                                                *\n");
> -#endif
>  #if defined(CONFIG_FTRACE) && !defined(CONFIG_FTRACE_MCOUNT_RECORD)
>  	printk(KERN_ERR "*        CONFIG_FTRACE                                                      *\n");
>  #endif


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/