linux-kernel - Re: [pnfs] [GIT BISECT] first bad commit: 1f36f774 Switch !O_CREAT case to use of do

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 25 Mar 2010 15:11:52 +0200
From:	Boaz Harrosh <bharrosh@...asas.com>
To:	Al Viro <viro@...IV.linux.org.uk>
CC:	pNFS Mailing List <pnfs@...ux-nfs.org>,
	"J. Bruce Fields" <bfields@...i.umich.edu>,
	Trond Myklebust <Trond.Myklebust@...app.com>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Doug Nazar <nazard.lkml@...il.com>,
	linux-fsdevel <linux-fsdevel@...r.kernel.org>
Subject: Re: [pnfs] [GIT BISECT] first bad commit: 1f36f774 Switch !O_CREAT
 case to use of do_last()

On 03/25/2010 03:00 PM, Boaz Harrosh wrote:
> On 03/25/2010 01:55 PM, Al Viro wrote:
>> On Thu, Mar 25, 2010 at 10:49:24AM +0000, Al Viro wrote:
>>
>>> Does that happen with nfsv3 or is that v4-only?  I'm going to set up v4
>>> server and client and see what happens, but that information could be
>>> useful...
>>
>> *grumble*
>> I'd managed to forget that rpc.imapd in its infinite wisdom relies on
>> the FPOS I normally disable.  Oh, well... rebuilding testbox kernel
>> with dnotify enabled ;-/
> 
> I just wanted to make sure, on top of 2.6.34-rc2 i did:
> git revert 781b16775ba0bb55fac0e1757bf0bd87c8879632
> 	Revert "Fix a dumb typo - use of & instead of &&"
> and:
> git revert 1f36f774b22a0ceb7dd33eca626746c81a97b6a5
> 	Revert "Switch !O_CREAT case to use of do_last()"
> 
> The revert is now clean and the problem does not show.
> Are you able to reproduce this? Anything I can do to help?
> 

I'm not sure I mentioned this. If you are able to reproduce the
error, then after the error in "git status" the tree becomes unusable.
Not even from the local_mount. I have not found a method to fix the tree.
So what I do is:
- Before I start playing I save "cp some_tree/.git/index index.back"
- then after the error and tree damage On local mount I:
  "rm some_tree/.git/index"
  "cp index.back cp some_tree/.git/index"
  "cd some_tree; git status"

this will fix it so I can try a new iteration

> Thanks
> Boaz
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/