linux-kernel - Re: [PATCH 14/16] Tools perf probe-finder.c: duplicated include

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 25 Mar 2010 13:42:32 -0400
From:	Masami Hiramatsu <mhiramat@...hat.com>
To:	Andrea Gelmini <andrea.gelmini@...ma.net>
CC:	linux-doc@...r.kernel.org, Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Paul Mackerras <paulus@...ba.org>, Ingo Molnar <mingo@...e.hu>,
	Arnaldo Carvalho de Melo <acme@...hat.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 14/16] Tools perf probe-finder.c: duplicated include

Hi Andrea,

Andrea Gelmini wrote:
> tools/perf/util/probe-finder.c: string.h is included more than once.

Would you mean that <string.h> and "string.h" are duplicated? 
If so, NAK, sorry. Those are different, <string.h> is for
/usr/include/string.h, and "string.h" is for tools/perf/util/string.h.

Thank you,

> 
> Signed-off-by: Andrea Gelmini <andrea.gelmini@...ma.net>
> ---
>  tools/perf/util/probe-finder.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/tools/perf/util/probe-finder.c b/tools/perf/util/probe-finder.c
> index 1e6c65e..682eb37 100644
> --- a/tools/perf/util/probe-finder.c
> +++ b/tools/perf/util/probe-finder.c
> @@ -32,7 +32,6 @@
>  #include <stdarg.h>
>  #include <ctype.h>
>  
> -#include "string.h"
>  #include "event.h"
>  #include "debug.h"
>  #include "util.h"

-- 
Masami Hiramatsu
e-mail: mhiramat@...hat.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/