linux-kernel - Re: [PATCH 1/4] isdn: Cleanup Sections in PCMCIA driver sedlbauer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 25 Mar 2010 11:58:46 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	isdn@...ux-pingi.de
Cc:	henne@...htwindheim.de, linux@...inikbrodowski.net,
	akpm@...ux-foundation.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/4] isdn: Cleanup Sections in PCMCIA driver sedlbauer

From: Karsten Keil <isdn@...ux-pingi.de>
Date: Thu, 25 Mar 2010 13:13:18 +0100

> On Donnerstag, 25. März 2010 13:05:29 Henrik Kretzschmar wrote:
>> Compiling this driver gave a section mismatch,
>> so I reviewed the init/exit paths of the driver
>> and made the correct changes.
>> 
>> WARNING: drivers/isdn/hisax/built-in.o(.text+0x558d6): Section mismatch
>> in reference from the function sedlbauer_config() to the function
>> .devinit.text:hisax_init_pcmcia()
>> The function sedlbauer_config() references
>> the function __devinit hisax_init_pcmcia().
>> This is often because sedlbauer_config lacks a __devinit
>> annotation or the annotation of hisax_init_pcmcia is wrong.
>> 
>> Signed-off-by: Henrik Kretzschmar <henne@...htwindheim.de>
> Acked-by: <keil@...systems.de>
> 
> Thank you for fixing this.

Thanks for reviewing Karsten.

Please put your proper name in your ACK lines in the
future, they should look just like Signed-off-by: lines.

I fixed this up when committing, thanks again.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/