| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Fri, 26 Mar 2010 11:44:15 -0400 From: Masami Hiramatsu <mhiramat@...hat.com> To: KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com> CC: Andrea Gelmini <andrea.gelmini@...ma.net>, linux-doc@...r.kernel.org, Peter Zijlstra <a.p.zijlstra@...llo.nl>, Paul Mackerras <paulus@...ba.org>, Ingo Molnar <mingo@...e.hu>, Arnaldo Carvalho de Melo <acme@...hat.com>, Frederic Weisbecker <fweisbec@...il.com>, linux-kernel@...r.kernel.org Subject: Re: [PATCH 14/16] Tools perf probe-finder.c: duplicated include KOSAKI Motohiro wrote: >> Hi Andrea, >> >> Andrea Gelmini wrote: >>> tools/perf/util/probe-finder.c: string.h is included more than once. >> >> Would you mean that <string.h> and "string.h" are duplicated? >> If so, NAK, sorry. Those are different, <string.h> is for >> /usr/include/string.h, and "string.h" is for tools/perf/util/string.h. >> >> Thank you, > > I think this discussion suggested "string.h" should be renameed more review > friendly name. probably. Hmm, we'd better review files under tools/utils/include too. :( (not sure why we have those files, because some files includes headers from original include directory, as like as "../../include/linux/blahblah.h") Thank you, -- Masami Hiramatsu e-mail: mhiramat@...hat.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists