lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Fri, 26 Mar 2010 18:43:20 +0100
From:	Frederic Weisbecker <fweisbec@...il.com>
To:	Peter Zijlstra <peterz@...radead.org>
Cc:	Ingo Molnar <mingo@...e.hu>, LKML <linux-kernel@...r.kernel.org>,
	Steven Rostedt <rostedt@...dmis.org>
Subject: Re: [PATCH] lockdep: Make lockstats counting per cpu

On Fri, Mar 26, 2010 at 08:48:34AM +0100, Peter Zijlstra wrote:
> On Fri, 2010-03-26 at 07:52 +0100, Peter Zijlstra wrote:
> > On Fri, 2010-03-26 at 03:22 +0100, Frederic Weisbecker wrote:
> > > We can't use irqsafe per cpu counters for that as
> > > these stats might be also written from NMI path, and irqsafe per
> > > cpu counters are not NMI safe, but local_t operations are.
> > > 
> > lockdep shouldn't do NMI, nmi_enter() has an explicit lockdep_off().
> 
> Also, more importantly, you simply should never use locks in NMI context
> to begin with ;-)


Right. I just thought ther could be some path that use rcu_read_lock
things there or whatever check. I mean, NMI don't need rcu_read_lock
but it could call helpers that use it.

Whatever, lockdep is off there. Looks like I can safely use per cpu counters.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ