linux-kernel - Re: [PATCH 2/2] ARM: pcmcia: fix checkpatch.pl issues in soc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 26 Mar 2010 18:18:00 +0000
From:	Russell King - ARM Linux <linux@....linux.org.uk>
To:	Sergei Shtylyov <sshtylyov@...sta.com>
Cc:	Marcelo Roberto Jimenez <mroberto@...i.cetuc.puc-rio.br>,
	linux-arm-kernel@...ts.infradead.org,
	linux-pcmcia@...ts.infradead.org,
	Wolfram Sang <w.sang@...gutronix.de>,
	Dominik Brodowski <linux@...inikbrodowski.net>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] ARM: pcmcia: fix checkpatch.pl issues in
	soc_common.c

On Thu, Mar 25, 2010 at 01:19:29PM +0300, Sergei Shtylyov wrote:
> Hello.
>
> Russell King - ARM Linux wrote:
>
>>> -	debug(skt, 2, "mask: %s%s%s%s%s%sflags: %s%s%s%s%s%sVcc %d Vpp %d irq %d\n",
>>> -			(state->csc_mask==0)?"<NONE> ":"",
>>> -			(state->csc_mask&SS_DETECT)?"DETECT ":"",
>>> -			(state->csc_mask&SS_READY)?"READY ":"",
>>> -			(state->csc_mask&SS_BATDEAD)?"BATDEAD ":"",
>>> -			(state->csc_mask&SS_BATWARN)?"BATWARN ":"",
>>> -			(state->csc_mask&SS_STSCHG)?"STSCHG ":"",
>>> -			(state->flags==0)?"<NONE> ":"",
>>> -			(state->flags&SS_PWR_AUTO)?"PWR_AUTO ":"",
>>> -			(state->flags&SS_IOCARD)?"IOCARD ":"",
>>> -			(state->flags&SS_RESET)?"RESET ":"",
>>> -			(state->flags&SS_SPKR_ENA)?"SPKR_ENA ":"",
>>> -			(state->flags&SS_OUTPUT_ENA)?"OUTPUT_ENA ":"",
>>> +	debug(skt, 2,	"mask: %s%s%s%s%s%s "
>>> +			"flags: %s%s%s%s%s%s Vcc %d Vpp %d irq %d\n",
>>>     
>>
>> NAK.  Breaking kernel messages across multiple lines makes them impossible
>> to grep for.  checkpatch.pl is wrong on this one.
>>   
>
>   I'd disagree in this case. Anybody will hardly grep for "mask:  
> %s%s%s%s%s%sflags: %s%s%s%s%s%s".

Well, I disagree on a matter of principle with you.  If you want to avoid
the line going over 80 columns, move the entire string onto the next line.
Then we can have the entire string intact _and_ we can have it fitting
within 80 columns.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/