linux-kernel - Re: [PATCH] Fix section mismatches in virtual framebuffer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 26 Mar 2010 22:37:58 +0100
From:	Henrik Kretzschmar <henne@...htwindheim.de>
To:	Randy Dunlap <randy.dunlap@...cle.com>
CC:	linux-fbdev@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	Krzysztof Helt <krzysztof.h1@...zta.fm>,
	Arnaud Patard <arnaud.patard@...-net.org>,
	Andres Salomon <dilinger@...ian.org>,
	Jaya Kumar <jayakumar.lkml@...il.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Fix section mismatches in virtual framebuffer

Sorry, this patch is crap.

These structures can be freed cause they are struct and not struct*
But they should be __devinitdata.

I'm going to resend this and a couple of other fb-patches tomorrow.

Thanks 

Randy Dunlap schrieb:

> [adding linux-fbdev mailing list]
>
> Acked-by: Randy Dunlap <randy.dunlap@...cle.com>
>
>
> On Wed, 24 Mar 2010 13:17:15 +0100 Henrik Kretzschmar wrote:
>
>   
>> Both structs, vfb_default and vfb_fix, should not be freed,
>> since they are referenced and used by the struct fb_info of that device.
>>
>> WARNING: drivers/video/vfb.o(.devinit.text+0x13f): Section mismatch in
>> reference from the function vfb_probe() to the variable
>> .init.data:vfb_default
>> The function __devinit vfb_probe() references
>> a variable __initdata vfb_default.
>> If vfb_default is only used by vfb_probe then
>> annotate vfb_default with a matching annotation.
>>
>> WARNING: drivers/video/vfb.o(.devinit.text+0x162): Section mismatch in
>> reference from the function vfb_probe() to the variable
>> .init.data:vfb_fix
>> The function __devinit vfb_probe() references
>> a variable __initdata vfb_fix.
>> If vfb_fix is only used by vfb_probe then
>> annotate vfb_fix with a matching annotation.
>>
>> WARNING: drivers/video/vfb.o(.devinit.text+0x177): Section mismatch in
>> reference from the function vfb_probe() to the variable
>> .init.data:vfb_fix
>> The function __devinit vfb_probe() references
>> a variable __initdata vfb_fix.
>> If vfb_fix is only used by vfb_probe then
>> annotate vfb_fix with a matching annotation.
>>
>> WARNING: drivers/video/vfb.o(.devinit.text+0x184): Section mismatch in
>> reference from the function vfb_probe() to the (unknown reference)
>> .init.data:(unknown)
>> The function __devinit vfb_probe() references
>> a (unknown reference) __initdata (unknown).
>> If (unknown) is only used by vfb_probe then
>> annotate (unknown) with a matching annotation.
>>
>> Signed-off-by: Henrik Kretzschmar <henne@...htwindheim.de>
>> ---
>>  drivers/video/vfb.c |    4 ++--
>>  1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/video/vfb.c b/drivers/video/vfb.c
>> index b8ab995..ae5796d 100644
>> --- a/drivers/video/vfb.c
>> +++ b/drivers/video/vfb.c
>> @@ -79,7 +79,7 @@ static void rvfree(void *mem, unsigned long size)
>>  	vfree(mem);
>>  }
>>  
>> -static struct fb_var_screeninfo vfb_default __initdata = {
>> +static struct fb_var_screeninfo vfb_default = {
>>  	.xres =		640,
>>  	.yres =		480,
>>  	.xres_virtual =	640,
>> @@ -101,7 +101,7 @@ static struct fb_var_screeninfo vfb_default __initdata = {
>>        	.vmode =	FB_VMODE_NONINTERLACED,
>>  };
>>  
>> -static struct fb_fix_screeninfo vfb_fix __initdata = {
>> +static struct fb_fix_screeninfo vfb_fix = {
>>  	.id =		"Virtual FB",
>>  	.type =		FB_TYPE_PACKED_PIXELS,
>>  	.visual =	FB_VISUAL_PSEUDOCOLOR,
>> -- 
>>     
>
>
> ---
> ~Randy
>
>   

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/