linux-kernel - Re: [PATCH] dmar: section mismatch cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 26 Mar 2010 14:58:04 -0700
From:	Chris Wright <chrisw@...s-sol.org>
To:	Henrik Kretzschmar <henne@...htwindheim.de>
Cc:	jbarnes@...tuousgeek.org, David.Woodhouse@...el.com,
	len.brown@...el.com, chrisw@...s-sol.org,
	suresh.b.siddha@...el.com, mingo@...e.hu, yu.zhao@...el.com,
	fenghua.yu@...el.com, weidong@...el.com, linux-pci@...r.kernel.org,
	linux-kernel@...r.kernel.org, iommu@...ts.linux-foundation.org
Subject: Re: [PATCH] dmar: section mismatch cleanup

* Henrik Kretzschmar (henne@...htwindheim.de) wrote:
> This patch fixes a section mismatch.
> 
> WARNING: drivers/pci/built-in.o(.text+0x182f5): Section mismatch in
> reference from the function dmar_ir_support() to the variable
> .init.data:acpi_slot_detected
> The function dmar_ir_support() references
> the variable __initdata acpi_slot_detected.
> This is often because dmar_ir_support lacks a __initdata
> annotation or the annotation of acpi_slot_detected is wrong.
> 
> Signed-off-by: Henrik Kretzschmar <henne@...htwindheim.de>

Acked-by: Chris Wright <chrisw@...s-sol.org>

> -int dmar_ir_support(void)
> +int __init dmar_ir_support(void)

> -extern int dmar_ir_support(void);
> +extern int dmar_ir_support(void) __init;

Nit, but prerfer to see:

-extern int dmar_ir_support(void);
+extern int __init dmar_ir_support(void);

thanks,
-chris
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/