lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 26 Mar 2010 07:31:11 +0530 From: Amit Shah <amit.shah@...hat.com> To: Anton Blanchard <anton@...ba.org> Cc: Benjamin Herrenschmidt <benh@...nel.crashing.org>, Greg Kroah-Hartman <gregkh@...e.de>, Linus Torvalds <torvalds@...ux-foundation.org>, linux-kernel@...r.kernel.org, linuxppc-dev@...abs.org, Rusty Russell <rusty@...tcorp.com.au>, Alan Cox <alan@...rguk.ukuu.org.uk>, tglx@...utronix.de, mingo@...e.hu, a.p.zijlstra@...llo.nl Subject: Re: [PATCH 4/7] hvc_console: Fix race between hvc_close and hvc_remove On (Fri) Mar 26 2010 [10:30:31], Anton Blanchard wrote: > > Hi, > > > And this suggests that hvc_kick() is called before hvc_task is > > initialised, ie, before hvc_init() is called. > > > > Does this help? > > Looks good, tests OK on my POWER5 box. Thanks! > > Tested-by: Anton Blanchard <anton@...ba.org> Thanks. Before I submit this patch, though, I'd like to see why hvc_kick() gets called before hvc_init. If I can get to it real quick, I'll do it, else I'll just queue this one up. > > diff --git a/drivers/char/hvc_console.c b/drivers/char/hvc_console.c > > index ba55bba..50ac983 100644 > > --- a/drivers/char/hvc_console.c > > +++ b/drivers/char/hvc_console.c > > @@ -285,6 +285,9 @@ EXPORT_SYMBOL_GPL(hvc_instantiate); > > /* Wake the sleeping khvcd */ > > void hvc_kick(void) > > { > > + if (!hvc_task) > > + return; > > + > > hvc_kicked = 1; > > wake_up_process(hvc_task); > > } Amit -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists