linux-kernel - Re: [PATCH 4/5] usb:Push BKL on open down into the drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201003291530.37183.oliver@neukum.org>
Date:	Mon, 29 Mar 2010 15:30:36 +0200
From:	Oliver Neukum <oliver@...kum.org>
To:	Jiri Kosina <jkosina@...e.cz>
Cc:	Greg KH <greg@...ah.com>, USB list <linux-usb@...r.kernel.org>,
	Mauro Carvalho Chehab <mchehab@...radead.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/5] usb:Push BKL on open down into the drivers

Am Montag 29 März 2010 12:04:51 schrieb Jiri Kosina:
> For hiddev, this causes a problem, as you introduced BKL into 
> hiddev_connect() exactly because of the proper dependency -- we have the 
> BKL there to avoid race after usb_register_dev() -- once the device node 
> has been created, open() could happen on it.

Hi,

it seems to me you cannot deadlock with the BKL and an rwsem,
as BKL will be dropped if a task blocks on the rwsem. This is not
a nice feature of the BKL to use. Do you have an alternative idea?

	Regards
		Oliver
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/