linux-kernel - Re: [PATCH] added S6E63M0 AMOLED LCD Panel driver.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 30 Mar 2010 19:55:01 -0400
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	InKi Dae <daeinki@...il.com>
Cc:	Pavel Machek <pavel@....cz>,
	linux-fbdev-devel@...ts.sourceforge.net,
	linux-kernel@...r.kernel.org, kyungmin.park@...sung.com
Subject: Re: [PATCH] added S6E63M0 AMOLED LCD Panel driver.

On Wed, 31 Mar 2010 11:41:54 +0900 InKi Dae <daeinki@...il.com> wrote:

> Hi Andrew,
> 
> all the calls to s6e63m0_panel_send_sequence() would return -EINVAL.
> by api_async() of driver/spi/spi.c

No, spi_async() does

	master->transfer(spi, message);

which can return at least EIO, EINPROGRESS, EINVAL or ETIMEDOUT.

> so I think that those return values aren't changed to other.
> 
> and final step is to check only whether the return value is 0 or not.
> if you still think that this code has minor problem or you want it to
> be corrected
> then I will patch this code to be corrected anytime.

It's a bug.

Also s6e63m0_power_on() is sloppy.  It again or's together disparate
errnos.  Then if _anything_ failed it returns hardwired -EIO, but it
should instead propagate the callee's errno back up to the caller.

And s6e63m0_power_on() can return -EFAULT in several places, which is
nonsensical.

None of this is very critical, just ... sloppy.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/