linux-kernel - Re: [PATCH] pl061: Trivial fix for offset value range checking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 7 Apr 2010 07:42:27 +0300
From:	Baruch Siach <baruch@...s.co.il>
To:	Axel Lin <axel.lin@...il.com>
Cc:	linux-kernel <linux-kernel@...r.kernel.org>,
	David Brownell <david-b@...bell.net>
Subject: Re: [PATCH] pl061: Trivial fix for offset value range checking

Hi Axel,

On Tue, Apr 06, 2010 at 01:33:09PM +0800, Axel Lin wrote:
> The valid offset value is 0..PL061_GPIO_NR-1,
> this patch corrects the offset value range checking.
> 
> Signed-off-by: Axel Lin <axel.lin@...il.com>

Acked-by: Baruch Siach <baruch@...s.co.il>

Thanks.

baruch

> ---
>  drivers/gpio/pl061.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/gpio/pl061.c b/drivers/gpio/pl061.c
> index 5ad8f77..8e0906a 100644
> --- a/drivers/gpio/pl061.c
> +++ b/drivers/gpio/pl061.c
> @@ -158,7 +158,7 @@ static int pl061_irq_type(unsigned irq, unsigned trigger)
>  	unsigned long flags;
>  	u8 gpiois, gpioibe, gpioiev;
> 
> -	if (offset < 0 || offset > PL061_GPIO_NR)
> +	if (offset < 0 || offset >= PL061_GPIO_NR)
>  		return -EINVAL;
> 
>  	spin_lock_irqsave(&chip->irq_lock, flags);
> -- 
> 1.5.4.3

-- 
                                                     ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch@...s.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/