linux-kernel - RE: [PATCH v3 3/6] RapidIO: Add Port-Write handling for EM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 13 Apr 2010 08:00:29 -0700
From:	"Bounine, Alexandre" <Alexandre.Bounine@....com>
To:	"Andrew Morton" <akpm@...ux-foundation.org>,
	"Alexandre Bounine" <abounine@...dra.com>
Cc:	<torvalds@...ux-foundation.org>, <mporter@...nel.crashing.org>,
	<linux-kernel@...r.kernel.org>, <linuxppc-dev@...ts.ozlabs.org>,
	<thomas.moll@...go.com>
Subject: RE: [PATCH v3 3/6] RapidIO: Add Port-Write handling for EM

Andrew Morton wrote:
> On Tue, 6 Apr 2010 17:22:38 -0400 Alexandre Bounine
<abounine@...dra.com> wrote:
> 
> >
> > From: Alexandre Bounine <alexandre.bounine@....com>
> >
> > Add RapidIO Port-Write message handling in the context
> > of Error Management Extensions Specification Rev.1.3.
> >
> > ...
> >
> > +static struct rio_dev *rio_get_comptag(u32 comp_tag, struct rio_dev
*from)
> > +{
> > +	struct list_head *n;
> > +	struct rio_dev *rdev;
> > +
> > +	WARN_ON(in_interrupt());
> 
> The check should be unneeded - lockdep will warn about this.

Thank you. I will remove it in my next set of patches. 

> 
> > +	spin_lock(&rio_global_list_lock);
> > +	n = from ? from->global_list.next : rio_devices.next;
> > +
> > +	while (n && (n != &rio_devices)) {
> > +		rdev = rio_dev_g(n);
> > +		if (rdev->comp_tag == comp_tag)
> > +			goto exit;
> > +		n = n->next;
> > +	}
> > +	rdev = NULL;
> > +exit:
> > +	spin_unlock(&rio_global_list_lock);
> > +	return rdev;
> > +}
> > +

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/