linux-kernel - Re: [PATCH 1/2] MTD: cfi_cmdset_0002: Add reboot notifier for AMD flashes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 14 Apr 2010 07:57:58 +0300
From:	Artem Bityutskiy <dedekind1@...il.com>
To:	Kevin Cernekee <cernekee@...il.com>
Cc:	dwmw2@...radead.org, saeed.bishara@...il.com,
	linux-mtd@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] MTD: cfi_cmdset_0002: Add reboot notifier for AMD
 flashes

On Tue, 2010-04-13 at 13:30 -0700, Kevin Cernekee wrote:
> +static int cfi_amdstd_reset(struct mtd_info *mtd)
> +{
> +	struct map_info *map = mtd->priv;
> +	struct cfi_private *cfi = map->fldrv_priv;
> +	int i, ret;
> +	struct flchip *chip;
> +
> +	for (i = 0; i < cfi->numchips; i++) {
> +
> +		chip = &cfi->chips[i];
> +
> +		spin_lock(chip->mutex);
> +
> +		ret = get_chip(map, chip, chip->start, FL_SHUTDOWN);
> +		if (!ret) {
> +			map_write(map, CMD(0xF0), chip->start);
> +			chip->state = FL_SHUTDOWN;
> +			put_chip(map, chip, chip->start);
> +		}
> +
> +		spin_unlock(chip->mutex);
> +	}
> +
> +	return 0;
> +}

Kevin, I'd suggest to document why you do this in the code, just for the
next generation, or for the archaeologists who will dig MTD code in the
future. 

-- 
Best Regards,
Artem Bityutskiy (Артём Битюцкий)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/