lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 16 Apr 2010 14:23:08 +1000 From: Dave Chinner <david@...morbit.com> To: Mel Gorman <mel@....ul.ie> Cc: linux-mm@...ck.org, linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org, Chris Mason <chris.mason@...cle.com>, KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>, Andi Kleen <andi@...stfloor.org>, Johannes Weiner <hannes@...xchg.org> Subject: Re: [PATCH 06/10] vmscan: Split shrink_zone to reduce stack usage On Thu, Apr 15, 2010 at 06:21:39PM +0100, Mel Gorman wrote: > shrink_zone() calculculates how many pages it needs to shrink from each > LRU list in a given pass. It uses a number of temporary variables to > work this out that then remain on the stack. This patch splits the > function so that some of the stack variables can be discarded. > > Signed-off-by: Mel Gorman <mel@....ul.ie> > --- > mm/vmscan.c | 29 +++++++++++++++++++---------- > 1 files changed, 19 insertions(+), 10 deletions(-) > > diff --git a/mm/vmscan.c b/mm/vmscan.c > index 1ace7c6..a374879 100644 > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -1595,19 +1595,14 @@ static unsigned long nr_scan_try_batch(unsigned long nr_to_scan, > return nr; > } > > -/* > - * This is a basic per-zone page freer. Used by both kswapd and direct reclaim. > - */ > -static void shrink_zone(struct zone *zone, struct scan_control *sc) > +/* Calculate how many pages from each LRU list should be scanned */ > +static void calc_scan_trybatch(struct zone *zone, > + struct scan_control *sc, unsigned long *nr) Needs "noinline_for_stack" to stop the compiler re-inlining it. Cheers, Dave. -- Dave Chinner david@...morbit.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists