linux-kernel - Re: [PATCH] srcu: add missing header file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 17 Apr 2010 18:06:17 -0700
From:	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
To:	Lai Jiangshan <laijs@...fujitsu.com>
Cc:	Tejun Heo <tj@...nel.org>, LKML <linux-kernel@...r.kernel.org>,
	Ingo Molnar <mingo@...e.hu>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] srcu: add missing header file

On Sat, Apr 17, 2010 at 07:13:53PM +0800, Lai Jiangshan wrote:
> 
> When I was writing a module, I hit this compile error.
> include/linux/srcu.h:39: error: field 'mutex' has incomplete type
> include/linux/srcu.h:41: error: field 'dep_map' has incomplete type
> 
> mutex.h is missed in srcu.h, but srcu.h uses struct mutex,
> so this patch adds this missing header file.
> 
> __percpu is defined in compiler.h which is included in mutex.h already.
> But I also include percpu.h because it names "__percpu".

Good catch!!!  Queued for 2.6.35.

							Thanx, Paul

> Signed-off-by: Lai Jiangshan <laijs@...fujitsu.com>
> ---
> diff --git a/include/linux/srcu.h b/include/linux/srcu.h
> index 4d5ecb2..675a16f 100644
> --- a/include/linux/srcu.h
> +++ b/include/linux/srcu.h
> @@ -27,6 +27,9 @@
>  #ifndef _LINUX_SRCU_H
>  #define _LINUX_SRCU_H
> 
> +#include <linux/percpu.h>
> +#include <linux/mutex.h>
> +
>  struct srcu_struct_array {
>  	int c[2];
>  };
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/