[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Tue, 20 Apr 2010 12:26:15 +1000
From: Anton Blanchard <anton@...ba.org>
To: Christoph Hellwig <hch@....de>
Cc: Jan Kara <jack@...e.cz>, Alexander Viro <viro@...iv.linux.org.uk>,
Jens Axboe <jens.axboe@...cle.com>,
Andrew Morton <akpm@...ux-foundation.org>,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Fix regression in O_DIRECT|O_SYNC writes to block
devices
Hi,
> Actually you can just drop this call entirely. sync_blockdev is an
> overcomplicated alias for filemap_write_and_wait on the block device
> inode, which is exactl what we did just before calling into ->fsync
>
> It might be worth to still drop i_mutex for the cache flush, though.
Thanks for the feedback Jan + Christoph. New patch on the way.
Anton
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists