linux-kernel - Re: [PATCH] Staging: batman-adv: fix checkpath.pl issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 20 Apr 2010 18:06:28 -0700
From:	Joe Perches <joe@...ches.com>
To:	Mikal Sande <mikal.sande@...il.com>
Cc:	andrew@...n.ch, lindner_marek@...oo.de, gregkh@...e.de,
	siwu@....tu-chemnitz.de, sdietrich@...ell.com,
	sven.eckelmann@....de, linus.luessing@....de,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: batman-adv: fix checkpath.pl issues

On Wed, 2010-04-21 at 02:49 +0200, Mikal Sande wrote:
> @@ -212,7 +212,9 @@ ssize_t bat_device_write(struct file *file, const char __user *buff,
>  	unsigned long flags;
>  
>  	if (len < sizeof(struct icmp_packet)) {
> -		bat_dbg(DBG_BATMAN, "batman-adv:Error - can't send packet from char device: invalid packet size\n");
> +		bat_dbg(DBG_BATMAN, "batman-adv:" +
> +			"Error - can't send packet from char device: " +
> +			"invalid packet size\n");

C doesn't use + for string concatenation.
Please compile test your changes before submitting them.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/