linux-kernel - [PATCH] kbtab: fix incorrect size parameter in usb_buffer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Wed, 21 Apr 2010 09:09:04 +0800
From:	Axel Lin <axel.lin@...il.com>
To:	linux-kernel <linux-kernel@...r.kernel.org>
Cc:	Josh Myer <josh@...hisanerd.com>, Dmitry Torokhov <dtor@...l.ru>,
	Greg KH <gregkh@...e.de>
Subject: [PATCH] kbtab: fix incorrect size parameter in usb_buffer_free

The size allocated by usb_buffer_alloc is 8, however the size free by
usb_buffer_free is 10.
This patch corrects the size parameter in usb_buffer_free.

Signed-off-by: Axel Lin <axel.lin@...il.com>
Cc: Dmitry Torokhov <dtor@...l.ru>
Cc: Greg KH <gregkh@...e.de>
---
 drivers/input/tablet/kbtab.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/input/tablet/kbtab.c b/drivers/input/tablet/kbtab.c
index 6682b17..76b5d52 100644
--- a/drivers/input/tablet/kbtab.c
+++ b/drivers/input/tablet/kbtab.c
@@ -182,7 +182,7 @@ static int kbtab_probe(struct usb_interface *intf,
const struct usb_device_id *i
        return 0;

  fail3:        usb_free_urb(kbtab->irq);
- fail2:        usb_buffer_free(dev, 10, kbtab->data, kbtab->data_dma);
+ fail2:        usb_buffer_free(dev, 8, kbtab->data, kbtab->data_dma);
  fail1:        input_free_device(input_dev);
        kfree(kbtab);
        return error;
@@ -197,7 +197,7 @@ static void kbtab_disconnect(struct usb_interface *intf)
                usb_kill_urb(kbtab->irq);
                input_unregister_device(kbtab->dev);
                usb_free_urb(kbtab->irq);
-               usb_buffer_free(interface_to_usbdev(intf), 10,
kbtab->data, kbtab->data_dma);
+               usb_buffer_free(interface_to_usbdev(intf), 8,
kbtab->data, kbtab->data_dma);
                kfree(kbtab);
        }
 }
-- 
1.5.4.3
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/