linux-kernel - Re: [PATCH] Staging: wlan-ng: fix many style warnings in hfa384x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 21 Apr 2010 11:03:49 -0700
From:	Greg KH <gregkh@...e.de>
To:	Alessandro Ghedini <al3xbio@...il.com>
Cc:	Andrew.Elwell@...il.com, mithlesh@...syssoft.com, svenne@...p.dk,
	jkosina@...e.cz, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: wlan-ng: fix many style warnings in
 hfa384x_usb.c

On Wed, Apr 21, 2010 at 07:29:10PM +0200, Alessandro Ghedini wrote:
> This patch fixes most of the style warnings found with checkpatch.pl in the
> hfa384x_usb.c file.
> 
> Signed-off-by: Alessandro Ghedini <al3xbio@...il.com>
> ---
>  drivers/staging/wlan-ng/hfa384x_usb.c |   59 ++++++++++++++++++--------------
>  1 files changed, 33 insertions(+), 26 deletions(-)
> 
> diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers/staging/wlan-ng/hfa384x_usb.c
> index 5df56f0..db819be 100644
> --- a/drivers/staging/wlan-ng/hfa384x_usb.c
> +++ b/drivers/staging/wlan-ng/hfa384x_usb.c
> @@ -62,7 +62,7 @@
>  *
>  * hfa384x_drvr_xxxconfig  An example of the drvr level abstraction. These
>  *			functions are wrappers for the RID get/set
> -*			sequence. They 	call copy_[to|from]_bap() and
> +*			sequence. They call copy_[to|from]_bap() and
>  *			cmd_access().	These functions operate on the
>  *			RIDs and buffers without validation.  The caller
>  *			is responsible for that.
> @@ -351,7 +351,9 @@ static int submit_rx_urb(hfa384x_t *hw, gfp_t memflags)
>  	hw->rx_urb_skb = skb;
>  
>  	result = -ENOLINK;
> -	if (!hw->wlandev->hwremoved && !test_bit(WORK_RX_HALT, &hw->usb_flags)) {
> +	if (!hw->wlandev->hwremoved && \
> +			!test_bit(WORK_RX_HALT, &hw->usb_flags)) {

As Joe pointed out, this isn't good form.

> @@ -451,7 +453,7 @@ static void hfa384x_usb_defer(struct work_struct *data)
>  	if (test_bit(WORK_RX_HALT, &hw->usb_flags)) {
>  		int ret;
>  
> -		usb_kill_urb(&hw->rx_urb);	/* Cannot be holding spinlock! */
> +		usb_kill_urb(&hw->rx_urb); /* Cannot be holding spinlock! */

Put stuff like this on the line before, not after the code please.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/