| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Wed, 21 Apr 2010 14:12:05 +0800 From: Amerigo Wang <xiyou.wangcong@...il.com> To: Jan Kiszka <jan.kiszka@....de> Cc: Amerigo Wang <xiyou.wangcong@...il.com>, trivial@...nel.org, linux-kernel@...r.kernel.org, user-mode-linux-devel@...ts.sourceforge.net, Jeff Dike <jdike@...toit.com> Subject: Re: [PATCH 4/5] uml: i386: Avoid redefinition of NR_syscalls On Tue, Apr 20, 2010 at 07:14:43PM +0200, Jan Kiszka wrote: >Amerigo Wang wrote: >> On Mon, Apr 19, 2010 at 11:53:07PM +0200, Jan Kiszka wrote: >>> The i386 subarch happens to pull in original NR_syscalls. Maybe we can >>> make that work for all host arch, but for now just avoid the clash by >>> using an all-upper-case name. >>> >> >> Where? > >Not sure if this answers your question: > > CC arch/um/kernel/skas/syscall.o >/data/linux-2.6/arch/um/kernel/skas/syscall.c:13:1: warning: >"NR_syscalls" redefined >In file included from /data/linux-2.6/arch/x86/include/asm/unistd.h:3, > from >/data/linux-2.6/arch/um/sys-i386/shared/sysdep/syscalls.h:6, > from /data/linux-2.6/arch/um/kernel/skas/syscall.c:10: >/data/linux-2.6/arch/x86/include/asm/unistd_32.h:349:1: warning: this is >the location of the previous definition > Ah, sure. I misunderstood your purpose, please do include the warning messages you are trying to fix in your patch description. Thanks! -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists