linux-kernel - [PATCH 11/11] staging: crystalhd: remove unneeded crystalhd_stop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 25 Apr 2010 22:42:58 +0900
From:	Yoichi Yuasa <yuasa@...ux-mips.org>
To:	Greg Kroah-Hartman <greg@...ah.com>
Cc:	yuasa@...ux-mips.org, Naren Sankar <nsankar@...adcom.com>,
	Jarod Wilson <jarod@...sonet.com>,
	Scott Davilla <davilla@....com>,
	Manu Abraham <abraham.manu@...il.com>,
	linux-kernel@...r.kernel.org
Subject: [PATCH 11/11] staging: crystalhd: remove unneeded
 crystalhd_stop_device() return code

Signed-off-by: Yoichi Yuasa <yuasa@...ux-mips.org>
---
 drivers/staging/crystalhd/crystalhd_hw.c |    9 ++-------
 1 files changed, 2 insertions(+), 7 deletions(-)

diff --git a/drivers/staging/crystalhd/crystalhd_hw.c b/drivers/staging/crystalhd/crystalhd_hw.c
index ba81d01..e407eb8 100644
--- a/drivers/staging/crystalhd/crystalhd_hw.c
+++ b/drivers/staging/crystalhd/crystalhd_hw.c
@@ -320,7 +320,7 @@ static bool crystalhd_start_device(struct crystalhd_adp *adp)
 	return true;
 }
 
-static bool crystalhd_stop_device(struct crystalhd_adp *adp)
+static void crystalhd_stop_device(struct crystalhd_adp *adp)
 {
 	uint32_t reg;
 
@@ -340,8 +340,6 @@ static bool crystalhd_stop_device(struct crystalhd_adp *adp)
 	reg = crystalhd_reg_rd(adp, PCIE_CLK_REQ_REG);
 	reg |= PCI_CLK_REQ_ENABLE;
 	crystalhd_reg_wr(adp, PCIE_CLK_REQ_REG, reg);
-
-	return true;
 }
 
 static crystalhd_rx_dma_pkt *crystalhd_hw_alloc_rx_pkt(struct crystalhd_hw *hw)
@@ -2291,10 +2289,7 @@ BC_STATUS crystalhd_hw_suspend(struct crystalhd_hw *hw)
 
 	crystalhd_put_ddr2sleep(hw);
 
-	if (!crystalhd_stop_device(hw->adp)) {
-		BCMLOG_ERR("Failed to Stop Device!!\n");
-		return BC_STS_ERROR;
-	}
+	crystalhd_stop_device(hw->adp);
 
 	return BC_STS_SUCCESS;
 }
-- 
1.7.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/