linux-kernel - Re: [PATCH] procfs: fix tid fdinfo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 26 Apr 2010 12:26:03 +0200
From:	Miklos Szeredi <mszeredi@...e.cz>
To:	Jerome Marchand <jmarchan@...hat.com>
Cc:	Alexey Dobriyan <adobriyan@...il.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Alexander Viro <viro@...iv.linux.org.uk>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Vic Abell <abe@...due.edu>
Subject: Re: [PATCH] procfs: fix tid fdinfo

On Mon, 2010-04-26 at 09:49 +0200, Jerome Marchand wrote:
> On 04/23/2010 10:07 PM, Miklos Szeredi wrote:
> > On Sat, 2010-04-24 at 22:27 +0300, Alexey Dobriyan wrote:
> >> On Fri, Apr 23, 2010 at 11:16:20AM -0700, Andrew Morton wrote:
> >>> On Fri, 23 Apr 2010 17:40:07 +0200
> >>>> -	DIR("fdinfo",    S_IRUSR|S_IXUSR, proc_fdinfo_inode_operations, proc_fd_operations),
> >>>> +	DIR("fdinfo",    S_IRUSR|S_IXUSR, proc_fdinfo_inode_operations, proc_fdinfo_operations),
> >>
> >>> hm, the code's been like that for over a year.  What are the
> >>> user-visible effects of the bug, and of this change?
> >>
> >> /proc/*/task/*/fdinfo contains symlinks to opened files like /proc/*/fd/
> >> which is cool bug :-)
> > 
> > Yeah, at least now we can see that someone has started using this
> > interface ;)
> 
> AFAIK there is still nobody using it, but lsof should use it, and 
> /proc/<pid>/task/<tid>/fd/ too. I haven't checked the code, but as it is
> now, it doesn't spot files open by a thread which does share its father's
> file descriptor table.

Yes, apparently "lsof" doesn't care about contents of /proc/$PID/task.
Well, tasks with separate file descriptor tables are rare, POSIX threads
share their descriptor tables.  But it would be nice if this were fixed.

Thanks,
Miklos


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/