linux-kernel - Re: [PATCH] Staging: comedi: fix coding style issues in comedi_fops.c This patch fixes coding style issues reported by scripts/checkpatch.pl Signed-off-by: Zachary Richey <zr.public@...il.com>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 5 May 2010 23:22:32 -0700
From:	Greg KH <greg@...ah.com>
To:	Zachary Richey <zr.public@...il.com>
Cc:	gregkh@...e.de, fmhess@...rs.sourceforge.net,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: comedi: fix coding style issues in
	comedi_fops.c This patch fixes coding style issues reported by
	scripts/checkpatch.pl Signed-off-by: Zachary Richey
	<zr.public@...il.com>

On Wed, May 05, 2010 at 10:39:47PM -0400, Zachary Richey wrote:
> ---
>  drivers/staging/comedi/comedi_fops.c |   56 +++++++++++++++++-----------------
>  1 files changed, 28 insertions(+), 28 deletions(-)
> 
> diff --git a/drivers/staging/comedi/comedi_fops.c b/drivers/staging/comedi/comedi_fops.c
> index aca9674..999cbb6 100644
> --- a/drivers/staging/comedi/comedi_fops.c
> +++ b/drivers/staging/comedi/comedi_fops.c
> @@ -598,20 +598,20 @@ copyback:
>  static int parse_insn(struct comedi_device *dev, struct comedi_insn *insn,
>  		      unsigned int *data, void *file);
>  /*
> - * 	COMEDI_INSNLIST
> - * 	synchronous instructions
> - *
> - * 	arg:
> - * 		pointer to sync cmd structure
> - *
> - * 	reads:
> - * 		sync cmd struct at arg
> - * 		instruction list
> - * 		data (for writes)
> - *
> - * 	writes:
> - * 		data (for reads)
> - */
> +*	COMEDI_INSNLIST
> +*	synchronous instructions
> +*
> +*	arg:
> +*		pointer to sync cmd structure
> +*
> +*	reads:
> +*		sync cmd struct at arg
> +*		instruction list
> +*		data (for writes)
> +*
> +*	writes:
> +*		data (for reads)
> +*/
>  /* arbitrary limits */
>  #define MAX_SAMPLES 256
>  static int do_insnlist_ioctl(struct comedi_device *dev, void *arg, void *file)
> @@ -736,7 +736,7 @@ static int check_insn_config_length(struct comedi_insn *insn,


What warning is this patch resolving?  The original looks correct, a
leading space is fine for something like a comment block like this.

confused,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/