linux-kernel - Re: [PATCH] Staging: wlags49_h2: fixed C99 comments style issues in wl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 10 May 2010 09:59:11 +0300
From:	Andy Shevchenko <andy.shevchenko@...il.com>
To:	"Prashant P. Shah" <pshah.mumbai@...il.com>
Cc:	gregkh@...e.de, akpm@...ux-foundation.org, pe1dnn@...at.org,
	ext-andriy.shevchenko@...ia.com, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: wlags49_h2: fixed C99 comments style issues in 
	wl_profile.c

On Sun, May 9, 2010 at 8:12 PM, Prashant P. Shah <pshah.mumbai@...il.com> wrote:
> This is a patch to the wl_profile.c file that fixes the C99 comments
> style issues found by the checkpatch.pl tool.
>
> Signed-off-by: Prashant P. Shah <pshah.mumbai@...il.com>
> ---
>  drivers/staging/wlags49_h2/wl_profile.c |   54 +++++++++++++++---------------
>  1 files changed, 27 insertions(+), 27 deletions(-)
>
> diff --git a/drivers/staging/wlags49_h2/wl_profile.c b/drivers/staging/wlags49_h2/wl_profile.c
> index 13ade70..4a3b64d 100644
> --- a/drivers/staging/wlags49_h2/wl_profile.c
> +++ b/drivers/staging/wlags49_h2/wl_profile.c

...

> @@ -118,17 +118,17 @@ int parse_yes_no(char *value);
>
>  int parse_yes_no(char *value)
>  {
> -int rc = 0;                                                                            //default to NO for invalid parameters
> +int rc = 0;                                                                            /* default to NO for invalid parameters */
>
>        if (strlen(value) == 1) {
>                if ((value[0] | ('Y'^'y')) == 'y')
>                        rc = 1;
> -//     } else {
> -//             this should not be debug time info, it is an enduser data entry error ;?
> -//             DBG_WARNING(DbgInfo, "%s invalid; will be ignored\n", PARM_NAME_MICROWAVE_ROBUSTNESS);
> +/*     } else {
> +               this should not be debug time info, it is an enduser data entry error ;?
> +               DBG_WARNING(DbgInfo, "%s invalid; will be ignored\n", PARM_NAME_MICROWAVE_ROBUSTNESS); */
In such case you have lost the internal comments. I think it should look like
/*
} else {
/* ... */
...
*/


>        }
>        return rc;
> -} // parse_yes_no
> +} /* parse_yes_no */
>
>
>  /*******************************************************************************


-- 
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/