linux-kernel - Re: [PATCH -mm] remove deprecated dma_sync_single and dma_sync

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 12 May 2010 16:28:03 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	FUJITA Tomonori <fujita.tomonori@....ntt.co.jp>
Cc:	linux-kernel@...r.kernel.org, Pete Eberlein <pete@...soray.com>,
	Ross Cohen <rcohen@...rgle.org>, Greg KH <greg@...ah.com>,
	linux-ia64@...r.kernel.org
Subject: Re: [PATCH -mm] remove deprecated dma_sync_single and dma_sync_sg
 API

On Tue, 11 May 2010 10:13:23 +0900
FUJITA Tomonori <fujita.tomonori@....ntt.co.jp> wrote:

> Since 2.6.5, it had been commented, 'for backwards compatibility,
> removed in 2.7.x'. Since 2.6.31, it have been marked as __deprecated.
> 
> I think that we can remove the API safely now.
> 
> Signed-off-by: FUJITA Tomonori <fujita.tomonori@....ntt.co.jp>
> ---
>  include/linux/dma-mapping.h |   15 ---------------
>  1 files changed, 0 insertions(+), 15 deletions(-)
> 
> diff --git a/include/linux/dma-mapping.h b/include/linux/dma-mapping.h
> index 2ea1494..89b7e1a 100644
> --- a/include/linux/dma-mapping.h
> +++ b/include/linux/dma-mapping.h
> @@ -95,21 +95,6 @@ static inline int is_device_dma_capable(struct device *dev)
>  #include <asm-generic/dma-mapping-broken.h>
>  #endif
>  
> -/* for backwards compatibility, removed soon */
> -static inline void __deprecated dma_sync_single(struct device *dev,
> -						dma_addr_t addr, size_t size,
> -						enum dma_data_direction dir)
> -{
> -	dma_sync_single_for_cpu(dev, addr, size, dir);
> -}
> -
> -static inline void __deprecated dma_sync_sg(struct device *dev,
> -					    struct scatterlist *sg, int nelems,
> -					    enum dma_data_direction dir)
> -{
> -	dma_sync_sg_for_cpu(dev, sg, nelems, dir);
> -}
> -
>  static inline u64 dma_get_mask(struct device *dev)
>  {
>  	if (dev && dev->dma_mask && *dev->dma_mask)

drivers/staging/go7007/saa7134-go7007.c uses dma_sync_single().

arch/ia64/kernel/machvec.c has functions machvec_dma_sync_single() and
machvec_dma_sync_sg() which might be dead code.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/