linux-kernel - Re: [trivial PATCH] arch/x86: Remove unnecessary returns from void function()'s

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 11 May 2010 21:37:44 -0700
From:	Joe Perches <joe@...ches.com>
To:	"H. Peter Anvin" <hpa@...or.com>
Cc:	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>, x86@...nel.org,
	LKML <linux-kernel@...r.kernel.org>,
	Jiri Kosina <trivial@...nel.org>
Subject: Re: [trivial PATCH] arch/x86: Remove unnecessary returns from void
 function()'s

On Tue, 2010-05-11 at 20:58 -0700, H. Peter Anvin wrote:
> On 05/11/2010 08:51 PM, Joe Perches wrote:
> > On Tue, 2010-05-11 at 20:37 -0700, H. Peter Anvin wrote:
> >> Churn is *not* motivated just
> >> for "consistency" unless it improves readability.
> > Consistency improves readability.
> As a general rule, sure.
> For any specific instance it is a big "it
> depends".

In these specific instances, in my opinion it does.
Your assertion is simply your opinion.
In the end, neither opinion matters much.

cheers, Joe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/