linux-kernel - Re: [PATCH] MMC: OMAP HS-MMC: convert to dev_pm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 13 May 2010 19:48:14 +0100
From:	Matt Fleming <matt@...sole-pimps.org>
To:	Kevin Hilman <khilman@...prootsystems.com>
Cc:	linux-omap@...r.kernel.org,
	Madhusudhan Chikkature <madhu.cr@...com>,
	Adrian Hunter <adrian.hunter@...ia.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Tony Lindgren <tony@...mide.com>,
	Denis Karpov <ext-denis.2.karpov@...ia.com>,
	linux-kernel@...r.kernel.org, linux-mmc@...r.kernel.org
Subject: Re: [PATCH] MMC: OMAP HS-MMC: convert to dev_pm_ops

On Tue, 11 May 2010 14:57:16 -0700, Kevin Hilman <khilman@...prootsystems.com> wrote:
> 
> Note that dev_pm_ops version of the suspend hook no longer takes a
> 'state' argument.  However, the MMC core function mmc_suspend_host()
> still takes a 'state' argument, but it is unused, so a dummy
> state variable was created to pass to the MMC core.

Hmm.. instead of passing this dummy state argument why don't we just
remove the argument from mmc_suspend_host()? Like you said, it's unused,
so I don't see a reason to keep it around?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/