linux-kernel - Re: [PATCH 3/8] block,ide: simplify bdops->set_capacity() to ->unlock_native

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 16 May 2010 00:15:52 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	tj@...nel.org
Cc:	jeff@...zik.org, linux-ide@...r.kernel.org, jens.axboe@...cle.com,
	linux-scsi@...r.kernel.org, James.Bottomley@...e.de,
	linux-kernel@...r.kernel.org, ben@...adent.org.uk,
	bzolnier@...il.com
Subject: Re: [PATCH 3/8] block,ide: simplify bdops->set_capacity() to
 ->unlock_native_capacity()

From: Tejun Heo <tj@...nel.org>
Date: Sat, 15 May 2010 20:09:29 +0200

> bdops->set_capacity() is unnecessarily generic.  All that's required
> is a simple one way notification to lower level driver telling it to
> try to unlock native capacity.  There's no reason to pass in target
> capacity or return the new capacity.  The former is always the
> inherent native capacity and the latter can be handled via the usual
> device resize / revalidation path.  In fact, the current API is always
> used that way.
> 
> Replace ->set_capacity() with ->unlock_native_capacity() which take
> only @disk and doesn't return anything.  IDE which is the only current
> user of the API is converted accordingly.
> 
> Signed-off-by: Tejun Heo <tj@...nel.org>

Acked-by: David S. Miller <davem@...emloft.net>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/