linux-kernel - Re: [PATCH, RFC] addjust discard request to be aligned with hwsect size to support SSDs with larger sector size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 16 May 2010 09:38:20 -0400
From:	Christoph Hellwig <hch@...radead.org>
To:	Jiaying Zhang <jiayingz@...gle.com>
Cc:	hch@...radead.org, jens.axboe@...cle.com,
	linux-kernel@...r.kernel.org, mrubin@...gle.com
Subject: Re: [PATCH, RFC] addjust discard request to be aligned with hwsect
	size to support SSDs with larger sector size

On Wed, May 12, 2010 at 10:19:53PM -0700, Jiaying Zhang wrote:
> The currect blkdev_issue_discard() function assumes 512 sector size.
> We have seen some problem when using discard on a SSD that has larger
> sector size. The following patch adjusts the starting address and size of
> a discard request to be aligned with hwsect size.

Looks good,


Reviewed-by: Christoph Hellwig <hch@....de>

> -	if (!blk_queue_discard(q))
> +	if (!blk_queue_discard(q) || q->limits.max_discard_sectors == 0)
>  		return -EOPNOTSUPP;

But this change is unrelated.  It's fine with me, but needs a patch of
it's own with a proper description.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/