linux-kernel - [tip:x86/mrst] x86, mrst, pci: return 0 for non-present pci bars

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 17 May 2010 06:33:48 GMT
From:	tip-bot for Jacob Pan <jacob.jun.pan@...ux.intel.com>
To:	linux-tip-commits@...r.kernel.org
Cc:	linux-kernel@...r.kernel.org, hpa@...or.com, mingo@...hat.com,
	jbarnes@...tuousgeek.org, tglx@...utronix.de, hpa@...ux.intel.com,
	jacob.jun.pan@...ux.intel.com
Subject: [tip:x86/mrst] x86, mrst, pci: return 0 for non-present pci bars

Commit-ID:  e4af4268a34d8cd28c46a03161fc017cbd2db887
Gitweb:     http://git.kernel.org/tip/e4af4268a34d8cd28c46a03161fc017cbd2db887
Author:     Jacob Pan <jacob.jun.pan@...ux.intel.com>
AuthorDate: Fri, 14 May 2010 14:41:14 -0700
Committer:  H. Peter Anvin <hpa@...ux.intel.com>
CommitDate: Sun, 16 May 2010 22:45:36 -0700

x86, mrst, pci: return 0 for non-present pci bars

Moorestown PCI code has special handling of devices with fixed BARs. In
case of BAR sizing writes, we need to update the fake PCI MMCFG space with real
size decode value.

When a BAR is not present, we need to return 0 instead of ~0. ~0 will be
treated as device error per bugzilla 12006.

Signed-off-by: Jacob Pan <jacob.jun.pan@...ux.intel.com>
LKML-Reference: <1273873281-17489-2-git-send-email-jacob.jun.pan@...ux.intel.com>
Acked-by: Jesse Barnes <jbarnes@...tuousgeek.org>
Acked-by: Thomas Gleixner <tglx@...utronix.de>
Signed-off-by: H. Peter Anvin <hpa@...ux.intel.com>
---
 arch/x86/pci/mrst.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/x86/pci/mrst.c b/arch/x86/pci/mrst.c
index 8bf2fcb..d5c7aef 100644
--- a/arch/x86/pci/mrst.c
+++ b/arch/x86/pci/mrst.c
@@ -109,7 +109,7 @@ static int pci_device_update_fixed(struct pci_bus *bus, unsigned int devfn,
 			decode++;
 			decode = ~(decode - 1);
 		} else {
-			decode = ~0;
+			decode = 0;
 		}
 
 		/*
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/